Fix hoveranywhere/clickanywhere events over editable shapes#7788
Open
Fix hoveranywhere/clickanywhere events over editable shapes#7788
hoveranywhere/clickanywhere events over editable shapes#7788Conversation
Contributor
|
Could you please provide testing instructions? I'm happy to paste a mock into devtools. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7787.
Editable shapes were swallowing
plotly_hover/plotly_clickevents, sohoveranywhere/clickanywherenever fired over them.Root cause:
dragElement.initsetselement.style.pointerEvents = 'all'inline on the shape path so it can receive drag events. That override beats the CSS rule that normally keeps the shape transparent to events, so mouse events stop at the shape and never reach thensewdragrect wherehoveranywhere/clickanywhereare wired up.The Fix:
Forward
mousemoveandclickfrom the shape path toFx.hover/Fx.click(with the shape's subplot id) whenhoveranywhere/clickanywhereis enabled and the user isn't mid-drag. This mirrors the pattern already used by the hover layer ingraph_interact.js.